Italian translations for vue of intro-to-storybook #756
Conversation
There was a problem hiding this comment.
@Archetipo95, thank you so much for taking the time to put together this pull request and helping our community get a better understanding of Storybook by extending our translations. We truly appreciate it 🙏 !
I left a couple of small items for you to look into when you have a moment.
Also, @ludovicobesana, when you have a moment, can you take a pass at this pull request from a language standpoint so we can polish it and release it?
Hope both of you have a great day.
Stay safe.
|
@jonniebigodes I fixed the issues that you mentioned in the comments. If you have something else feel free to give me a feedback! |
|
@Archetipo95 appreciate you addressing the feedback so promptly 🙏 ! From my end, all is good. I'll message @ludovicobesana tomorrow morning my time and see if he has time to take a look into this, so that we're able to get the feedback addressed as soon as possible and publish the translation. If he's unable to review it in a reasonable timeframe. I'll go ahead and merge this, and we can make some adjustments in a follow-up pull request. Sounds reasonable to you? Have a fantastic day. Stay safe |
|
Absolutely, it sounds awesome! Addressing feedback promptly is crucial for maintaining momentum 🚀 Wishing you a fantastic day as well! |
|
@jonniebigodes I'll do the review by Sunday 7th. |
|
Appreciate it @ludovicobesana 🙏 |
|
@Archetipo95 I'm looking it right now in code from here: https://github.com/Archetipo95/learnstorybook.com/tree/master |
|
@Archetipo95 I've done a quick review, could you please check the feedbacks that I've added? Now I need to go but tomorrow I'll check if I found other things that can be improved. cc. @jonniebigodes |
|
@jonniebigodes I resolved all the suggestions that @ludovicobesana raised. If you want to close it feel free :D |
Hi @Archetipo95, I see only one commit with one fix: e6711b4 Can you please look a the other feedbacks that I've added for you? |
|
Hi :D @ludovicobesana I did both fixes in one commit |
@Archetipo95 I've re-added this points and also if you can check also the other new parts of translations that could be great! |
|
Done! Sorry I messed something and I was not seeing your suggestions :D thanks for tagging me @ludovicobesana |
Cool thank you, did you check the other documentation files too? |
|
@Archetipo95 and @ludovicobesana can you give me a status update on this pull request so that we can continue to work on it or get it out? Let me know and we'll go from there. Have a fantastic day the both of you. |
|
@jonniebigodes I did the suggestions that @ludovicobesana made and I'm done with this Pull Request for now. :) |
|
Hi @jonniebigodes if @Archetipo95 has resolved all the points and reviewed the other files I think that we can merge it 🚀 |
|
@Archetipo95, I appreciate you following up with me on this, and I will merge this so we can get it published. One small thing to take care of, @Archetipo95. If you're ok with it, can you message me directly (same username) on our Discord Server so that I can follow up with you on this pull request? @ludovicobesana cannot thank you enough for your time in getting this proofread 🙇 Hope both of you have a great day. Stay safe |
Huge thanks to @ludovicobesana for the React translations which I took for this Vue translation