Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: disableAutoSnapshot not working as expected #134

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

jackleslie
Copy link

@jackleslie jackleslie commented May 10, 2024

Issue: #131

What Changed

From documentation:

When true, will disable the snapshot that happens automatically at the end of a test when using the Chromatic test fixture.

I believe currently when disableAutoSnapshot is set to true we are not proceeding to the prepareArchives task, so rather than disabling the automatic snapshot we are disabling all snapshots

How to test

  1. set disableAutoSnapshot: true globally
  2. call cy.takeSnapshot()

@jackleslie jackleslie marked this pull request as ready for review May 10, 2024 16:03
@tevanoff tevanoff requested a review from skitterm May 10, 2024 16:40
@jackleslie
Copy link
Author

Hi there @tevanoff @skitterm, just wanted to bump this hope that's okay 🙏

@skitterm
Copy link
Member

@jackleslie thanks for identifying the issue and making the fix! We'll take a look at this.

Fix the linting error
Fix linting
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants