Use current working directory as default value for storybookBaseDir

[ghengeveld]

getDependentStoryFiles has always used the current working directory as base directory when storybookBaseDir isn't set, making it zero-config in most cases. checkStorybookBaseDir wasn't behaving in the same way, causing it to throw an error when it shouldn't. This update fixes this inconsistency by using the current working directory relative to the repository root as the default value for storybookBaseDir.

📦 Published PR as canary version: 11.3.3--canary.976.9004196764.0

✨ Test out this PR locally via:

npm install chromatic@11.3.3--canary.976.9004196764.0
# or 
yarn add chromatic@11.3.3--canary.976.9004196764.0

[codacy-production]

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation	Diff coverage
Report missing for da800dd1	✅ 100.00% (target: 80.00%)

Coverage variation details

	Coverable lines	Covered lines	Coverage
Common ancestor commit (da800dd)	Report Missing	Report Missing	Report Missing
Head commit (3d44093)	8452	6650	78.68%

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details

	Coverable lines	Covered lines	Diff coverage
Pull request (#976)	4	4	100.00%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

_{Codacy will stop sending the deprecated coverage status from June 5th, 2024. Learn more}

Footnotes

1. Codacy didn't receive coverage data for the commit, or there was an error processing the received data. Check your integration for errors and validate that your coverage setup is correct. ↩

[andrewortwein]

🗂️👍🏻

[ghengeveld]

🚀 PR was released in v11.3.2 🚀

[Botffy]

That's nice, I'm truly grateful for the fix, but since the Github action still has the same version ("chromaui/action@v1"), it broke our build that we hacked to work around the issue. Is there a possibility to version the Github action in the future to avoid such issues?

Edit: ah I see, I can actually get earlier versions at https://github.com/chromaui/action/tags , and it's just the "v1" that changes constantly, good to know. I couldn't get the new version to work with our setup, btw, but I guess that should go to a different issue.