Properly check storybookBaseDir against repository root rather than CWD
#974
Conversation
…urrent working directory
| @@ -22,7 +24,7 @@ export async function checkStorybookBaseDir(ctx: Context, stats: Stats) { | |||
| await Promise.any( | |||
| sourceModuleFiles.map((file) => { | |||
| return limitConcurrency(() => { | |||
| const absolutePath = path.join(storybookBaseDir, file.name); | |||
| const absolutePath = path.join(repositoryRoot, storybookBaseDir, file.name); | |||
There was a problem hiding this comment.
@ghengeveld What is the validity of this suggestion? It seems fair.
ghengeveld
added
release
![codacy-production[bot]](https://avatars.githubusercontent.com/in/56611?s=60&v=4){kind=small}
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferencesCodacy will stop sending the deprecated coverage status from June 5th, 2024. Learn more Footnotes
|
|
🚀 PR was released in |
The
storybookBaseDiroption was being checked as a relative path, which causedcheckStorybookBaseDirto fail when running Storybook from a subdirectory rather than the repository root. This PR ensures we use the repository root rather than the current working directory when checking thestorybookBaseDirvalue.📦 Published PR as canary version:
11.3.2--canary.974.8981931033.0✨ Test out this PR locally via:
npm install chromatic@11.3.2--canary.974.8981931033.0 # or yarn add chromatic@11.3.2--canary.974.8981931033.0