Throw user-friendly error when config file fails to parse as JSON #961
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferencesYou may notice some variations in coverage metrics with the latest Coverage engine update. For more details, visit the documentation |
ghengeveld
force-pushed
the
ghengeveld/247-configuration-file-json-parse-error
branch
from
3a12043
to
2a11ca3
Compare
ghengeveld
added
release
ghengeveld
deleted the
ghengeveld/247-configuration-file-json-parse-error
branch
|
🚀 PR was released in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes chromaui/addon-visual-tests#247
If the Chromatic config file contains invalid JSON, a parse error is thrown in the CLI and printed by the Storybook process. The CLI did already have some handling of this scenario but it wasn't covering every type of JSON syntax error. This update will make it print a nicer error message that includes the config file path so people will know where to look.
📦 Published PR as canary version:
11.3.0--canary.961.8469857131.0✨ Test out this PR locally via:
npm install chromatic@11.3.0--canary.961.8469857131.0 # or yarn add chromatic@11.3.0--canary.961.8469857131.0