Skip to content

Commit

Permalink
tools/test: Add --all option to alias --all-files --platforms both.
Browse files Browse the repository at this point in the history
And promote it in the release docs and run it in CI.

As Greg suggests:
  zulip#4700 (comment).
  • Loading branch information
chrisbobbe committed Apr 29, 2021
1 parent 0bdc763 commit 6ba5e82
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 3 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ jobs:
uses: bahmutov/npm-install@v1

- name: Run tools/test
run: TERM=dumb tools/test --all-files --platform both
run: TERM=dumb tools/test --all

- run: tools/verify-webview-js

Expand Down
2 changes: 1 addition & 1 deletion docs/howto/release.md
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@ simple terminology for the process we follow with both.
our translation contributors. See
[howto/translations.md](translations.md) for background.

* Check that tests pass: `tools/test --all-files --platform both`.
* Check that tests pass: `tools/test --all`.

* Run `tools/bump-version` to update the version number in the
Android and iOS build metadata.
Expand Down
5 changes: 4 additions & 1 deletion tools/test
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ set -e

usage() {
cat >&2 <<EOF
usage: tools/test [--all-files | --diff COMMIT] [--platform <ios|android|both|sloppy>] [SUITES]
usage: tools/test [--all-files | --diff COMMIT] [--platform <ios|android|both|sloppy>] [--all] [SUITES]
Run our tests.
Expand Down Expand Up @@ -50,6 +50,8 @@ Options:
(E.g., \`--diff @\` for files with uncommitted changes;
\`--diff @~10\` for files changed in last 10 commits; or see
\`git help revisions\` for many more ways to name a commit.)
--all In the given suites, run all tests on all files. Same as
--all-files --platforms both.
Suites:
native
Expand Down Expand Up @@ -82,6 +84,7 @@ while (( $# )); do
esac
shift
;;
--all) files=all; platform=both; shift;;
--fix) fix=1; shift;;
native|flow|lint|jest|prettier|deps)
suites+=("$1"); shift;;
Expand Down

0 comments on commit 6ba5e82

Please sign in to comment.