Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add body to swagger for login endpoint #39

Merged
merged 2 commits into from
Nov 3, 2023
Merged

Conversation

cherylli
Copy link
Collaborator

@cherylli cherylli commented Nov 3, 2023

Description

Add body to swagger so frontend doesn't have to login with postman or equivalent, which means it would also add cookie to the swagger browser

I also had to add the windows code for husky (after I "fixed" husky locally) otherwise I can't push at all, see #32

image

Issue link

Fixes # (issue)

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

tested locally

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Copy link
Contributor

@kennytram kennytram left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Collaborator

@curtwl curtwl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested with Swagger, LGTM. Access token contains email and user ID.

@cherylli cherylli self-assigned this Nov 3, 2023
@cherylli cherylli merged commit 753d80d into dev Nov 3, 2023
1 check passed
@cherylli cherylli deleted the fix/auth-swagger-login-body branch November 3, 2023 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants