fix(http-proxy): remove disallowed headers when response headers contains trailer #830
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ins trailer Signed-off-by: zibo <ziboilihua@gmail.com>
chimurai
reviewed
Oct 3, 2022
| @@ -12,6 +12,19 @@ type Interceptor = ( | |||
| res: http.ServerResponse | |||
| ) => Promise<Buffer | string>; | |||
|
|
|||
| const TrailerDisallowHeaders: string[] = [ | |||
There was a problem hiding this comment.
Could you add a link to verify the completeness of these headers?
There was a problem hiding this comment.
Signed-off-by: zibo <ziboilihua@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Process will exit when proxy response header both contains
trailerand disallow headers eg.content-lengthMotivation and Context
How has this been tested?
I've created e2e test for this case, and all unit tests passed.
Types of changes
Checklist: