Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed 'pip install cheroot' on Python 2 #211

Closed
wants to merge 1 commit into from
Closed

Fixed 'pip install cheroot' on Python 2 #211

wants to merge 1 commit into from

Conversation

marc1n
Copy link
Contributor

@marc1n marc1n commented Jul 10, 2019 •
edited

❓ What kind of change does this PR introduce?

  • 🐞 bug fix

❓ What is the current behavior? (You can also link to an open issue here)

On Python 2 "pip install cheroot" ends with error:
ERROR: more-itertools requires Python '>=3.4' but the running Python is 2.7.15

The reason: more_itertools package from version 6 does not support Python 2.

This change is Reviewable

@marc1n
Fixed 'pip install cheroot' on Python 2
fac2825 
On Python 2 "pip install cheroot" ends with error:
ERROR: more-itertools requires Python '>=3.4' but the running Python is 2.7.15

The reason: more_itertools package from version 6 does not support Python 2.
@marc1n
Copy link
Contributor Author

marc1n commented Jul 10, 2019

There is a problem with test 'test_tls_client_auth[2-False-localhost-builtin]'. I think the test's failure is not related with my change.

webknjaz
webknjaz reviewed Jul 15, 2019
View reviewed changes
Copy link
Member

@webknjaz webknjaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm curious what version of Pip you are using. It should resolve the metadata properly by itself.

setup.cfg
@@ -63,7 +63,8 @@ setup_requires =
install_requires =
backports.functools_lru_cache
six>=1.11.0
more_itertools>=2.6
more_itertools>=2.6<6; python_version<'3'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The comma is missing

Suggested change
more_itertools>=2.6<6; python_version<'3'
more_itertools>=2.6,<6; python_version<'3'

@marc1n
Copy link
Contributor Author

marc1n commented Jul 15, 2019

$ pip --version
pip 18.0 from /home/.../lib/python2.7/site-packages/pip (python 2.7)

@marc1n
Copy link
Contributor Author

marc1n commented Jul 15, 2019 •
edited

I've updated pip to the newest version (19.1.1) and the issue is still valid.

@webknjaz
Copy link
Member

Please share the log of that.

@webknjaz
Copy link
Member

I'm pretty sure you're hitting more-itertools/more-itertools#272 (comment).
Could you please share an asciinema recording of the whole process with the Pip version check?

webknjaz
webknjaz requested changes Jul 15, 2019
View reviewed changes
Copy link
Member

@webknjaz webknjaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awaiting for more details + a syntax error fix

@webknjaz webknjaz added help wanted Somebody help us, please! question StackOverflow reproducer: missing This PR or issue lacks code, which reproduce the problem described or clearly understandable STR labels Jul 15, 2019
@marc1n
Copy link
Contributor Author

marc1n commented Jul 18, 2019 •
edited

I've found the problem exists if I use my local pypi mirror.
If I 'pip install' from public pypi.org than everything is OK.

@marc1n
Copy link
Contributor Author

marc1n commented Jul 18, 2019

Installing from local pypi:

$ pip install more-itertools
Looking in indexes: http://pypi.local
Collecting more-itertools
  Downloading http://devpi.local/root/pypi/%2Bf/8bb/43d1f51ecef60/more-itertools-7.1.0.tar.gz (71kB)
     |████████████████████████████████| 71kB 66.9MB/s 
ERROR: more-itertools requires Python '>=3.4' but the running Python is 2.7.15

@webknjaz
Copy link
Member

So the problem is that you don't have a compatible version in your index. Just add proper dists there and you should be fine.

@marc1n
Copy link
Contributor Author

marc1n commented Jul 18, 2019 •
edited

It seems that this is a problem of dev-server package (devpi/devpi#511) fixed in 4.7.0 version.

@webknjaz
Copy link
Member

makes sense

@marc1n
Copy link
Contributor Author

marc1n commented Jul 18, 2019

Anyway, thanks for support!

@webknjaz
Copy link
Member

You're welcome :)

@webknjaz webknjaz closed this Jul 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@webknjaz webknjaz webknjaz requested changes

Assignees
No one assigned
Labels
help wanted Somebody help us, please! question StackOverflow reproducer: missing This PR or issue lacks code, which reproduce the problem described or clearly understandable STR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@marc1n @webknjaz