Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix TLS 1.3 client tests with requests #192

Merged
merged 6 commits into from Apr 22, 2019

Conversation

webknjaz
Copy link
Member

@webknjaz webknjaz commented Apr 22, 2019

❓ What kind of change does this PR introduce?

  • 🐞 bug fix
  • 🐣 feature
  • πŸ“‹ docs update
  • πŸ“‹ tests/coverage improvement
  • πŸ“‹ refactoring
  • πŸ’₯ other

πŸ“‹ What is the related issue number (starting with #)

Closes #173

❓ What is the current behavior? (You can also link to an open issue here)

OpenSSL.SSL.Error happens.

❓ What is the new behavior (if this is a feature change)?

No OpenSSL.SSL.Error.

πŸ“‹ Other information:

Ref https://github.com/kennethreitz/requests/issues/4961
Ref urllib3/urllib3#1496

πŸ“‹ Checklist:

  • I think the code is well written
  • I wrote good commit messages
  • I have squashed related commits together after the changes have been approved
  • Unit tests for the changes exist
  • Integration tests for the changes exist (if applicable)
  • I used the same coding conventions as the rest of the project
  • The new code doesn't generate linter offenses
  • Documentation reflects the changes
  • The PR relates to only one subject with a clear title
    and description in grammatically correct, complete sentences

This change is Reviewable

@webknjaz webknjaz added bug Something is broken enhancement Improvement labels Apr 22, 2019
@codecov

This comment has been minimized.

@webknjaz webknjaz changed the title Bugfix/tests tls client 1.3 requests Fix TLS 1.3 client tests with requests Apr 22, 2019
@webknjaz webknjaz merged commit b4a0d7f into master Apr 22, 2019
@webknjaz webknjaz deleted the bugfix/tests-tls-client-1.3-requests branch December 7, 2020 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something is broken enhancement Improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SSL tests fail with uncaught SSL validation
1 participant