Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix SciPy cumtrapz deprecation warning #437

Merged
merged 2 commits into from
May 16, 2024
Merged

Fix SciPy cumtrapz deprecation warning #437

merged 2 commits into from
May 16, 2024

Conversation

vsnever
Copy link
Member

@vsnever vsnever commented May 13, 2024

This PR fixes SciPy DeprecationWarning (#436):

DeprecationWarning: 'scipy.integrate.cumtrapz' is deprecated in favour of 'scipy.integrate.cumulative_trapezoid' and will be removed in SciPy 1.14.0

when performing any calculations with the Beam object configured to use SingleRayAttenuator.

@vsnever vsnever linked an issue May 13, 2024 that may be closed by this pull request
SciPy deprecation warning for scipy.integrate.cumtrapz #436
Closed
jacklovell
jacklovell approved these changes May 14, 2024
View reviewed changes
Copy link
Member

@jacklovell jacklovell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine with me. A pragmatic workaround to a highly questionable decision by the scipy developers.

@jacklovell jacklovell merged commit f0a43f2 into cherab:development May 16, 2024
8 checks passed
@vsnever vsnever mentioned this pull request May 17, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jacklovell jacklovell jacklovell approved these changes

@Mateasek Mateasek Awaiting requested review from Mateasek

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

SciPy deprecation warning for scipy.integrate.cumtrapz
2 participants
@vsnever @jacklovell