Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix IRVB calculate sensitivity method #428

Merged
merged 1 commit into from
Mar 28, 2024
Merged

Fix IRVB calculate sensitivity method #428

merged 1 commit into from
Mar 28, 2024

Conversation

jacklovell
Copy link
Member

Spectral pipelines have no display_progress option.

Spectral pipelines have no display_progress option.
@jacklovell jacklovell marked this pull request as ready for review March 28, 2024 16:05
@jacklovell jacklovell requested a review from vsnever March 28, 2024 16:05
@jacklovell
Copy link
Member Author

I thought about adding some test coverage for this, but it's going to be quite involved creating a minimal working example for unit tests that doesn't take ages to run while having good enough statistics for a meaningful test for correctness. Maybe when we have more Generomak observers we can think about adding some test coverage for the cherab.tools.observers classes.

Copy link
Member

@vsnever vsnever left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me. Thanks!

@vsnever vsnever merged commit 42d6e74 into development Mar 28, 2024
16 checks passed
@jacklovell jacklovell deleted the irvb-bugfix branch April 2, 2024 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants