Package demo scripts and data in sdists and wheels #408
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This enables users who haven't cloned the git repository to still run the demos. A few unnecessary entries were removed from MANIFEST.in too. TODO: see whether we can get rid of MANIFEST.in completely and use setuptools' find_packages and package_data instead.
…ually This allows finer control over what gets packaged, and fixes a deprecation warning in recent setuptools versions (see pypa/setuptools#3308 for detais). It also prevents Cython-transpiled C source files being included in the wheel distribution, which roughly halves the size of the installed distribution.
vsnever
approved these changes
May 3, 2023
There was a problem hiding this comment.
Thanks, @jacklovell. I've checked that it works on Mac as well. On Mac, the demos are installed in Library/Python/3.xx/share instead of .local/share.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This enables users who haven't cloned the git repository to still run the demos. Use distutils/setuptools' support for
data_filesto achieve this.Also remove MANIFEST.in and
include_package_data=True, use setuptools'find_packagesandpackage_datainstead. This allows finer control over what gets packaged, and fixes a deprecation warning in recent setuptools versions (seepypa/setuptools#3308 for details). It also prevents Cython-transpiled C source files being included in the wheel distribution, which roughly halves the size of the installed distribution.