Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

windows print: enable virtual terminal processing #214

Merged

Conversation

vyasgun
Copy link
Contributor

@vyasgun vyasgun commented Jan 25, 2024

Disabling ENABLE_ECHO_INPUT during SetConsoleMode is causing issues rendering color on windows terminals as the same address is being used to ENABLE_VIRTUAL_TERMINAL_PROCESSING which is required for parsing colors.

Docs for reference: https://learn.microsoft.com/en-us/windows/console/setconsolemode

Copy link

@gbraad gbraad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as expected

@cheggaaa
Copy link
Owner

#213
Thanks!

@cheggaaa cheggaaa merged commit 85958a1 into cheggaaa:master Jan 25, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants