Fix segfault if high-entropy 64-bit ASLR is enabled #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GabrielNagy
force-pushed
the
fix-high-entropy-aslr-segfault
branch
from
89a2ffb
to
5c5527e
Compare
|
Nice catch. Can you check this with JRuby? I seem to recall having problems in the past with Update: aha, yep, I ended up doing this for sys-proctable: https://github.com/djberg96/sys-proctable/blob/master/lib/darwin/sys/proctable.rb#L298-L303 |
|
Traced that back to jruby/jruby#5948. I'll add the workaround to account for older JRuby versions, thanks for the heads-up 😄. |
If the High-entropy ASLR setting is enabled on Windows, `win32/dir` will segfault when calling `SHGetFileInfo`. Enabling high-entropy ASLR will cause processes to use the entire 64-bit address space, and the `long` data type is not large enough to hold a 64-bit address for the PIDL structure (which is the first argument of `SHGetFileInfo`[1]). As a result, the call segfaults. Change the parameter's data type to `uint64` to ensure that the address will always fit. [1] https://docs.microsoft.com/en-us/windows/win32/api/shellapi/nf-shellapi-shgetfileinfow Signed-off-by: Gabriel Nagy <gabriel.nagy@puppet.com>
GabrielNagy
force-pushed
the
fix-high-entropy-aslr-segfault
branch
from
5c5527e
to
cf3e31e
Compare
|
Hi folks, it looks like Windows github runners enabled ASLR causing our puppet#6.x builds to fail. We're still pinned to win32-dir 0.4.9 due to still supporting ruby 2.3 and up. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the High-entropy ASLR setting is enabled on Windows,
win32/dirwill segfault when callingSHGetFileInfo.Enabling high-entropy ASLR will cause processes to use the entire 64-bit address space, and the
longdata type is not large enough to hold a 64-bit address for the PIDL structure (which is the first argument ofSHGetFileInfo[1]). As a result, the call segfaults.[1] https://docs.microsoft.com/en-us/windows/win32/api/shellapi/nf-shellapi-shgetfileinfow
Description
Change the parameter's data type to
uint64to ensure the PIDL address will always fit.Issues Resolved
https://tickets.puppetlabs.com/browse/PUP-10622
Check List