Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Ruby versions released in March 2023 #1792

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Add Ruby versions released in March 2023 #1792

wants to merge 4 commits into from

Conversation

rfpronk
Copy link
Contributor

@rfpronk rfpronk commented Apr 24, 2023 •
edited

Description

Add hashes for new Ruby versions released in March 2023 and set default to latest 3.2.2

Related Issue

Supersedes #1774

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (non-breaking change that does not add functionality or fix an issue)

Checklist:

  • I have read the CONTRIBUTING document.
  • I have run the pre-merge tests locally and they pass.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • All commits have been signed-off for the Developer Certificate of Origin.

@rfpronk
Add Ruby versions released in March 2023
570fc61 
Signed-off-by: Robin F. Pronk <robin.pronk@nedap.com>
@sonarcloud
Copy link

sonarcloud bot commented Apr 24, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
10.5% 10.5% Duplication

@rfpronk rfpronk marked this pull request as ready for review April 24, 2023 10:39
@rfpronk rfpronk requested review from a team as code owners April 24, 2023 10:39
@rfpronk
Copy link
Contributor Author

rfpronk commented Jun 6, 2023

Can I get a review on this?

@tpowell-progress
Copy link
Contributor

@sean-simmons-progress @vkarve-chef any concerns with this disrupting current builders? I would like to assume not, but I figure you might have more insight into potential gotchas.

@rfpronk
Process comments
2638f70 
Signed-off-by: Robin F. Pronk <robin.pronk@nedap.com>
@sonarcloud
Copy link

sonarcloud bot commented Jun 30, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
10.5% 10.5% Duplication

@rfpronk
Copy link
Contributor Author

rfpronk commented Jun 30, 2023

Thanks for your replies. I was away on holiday for a bit. I changed the requested things

@rfpronk
Merge remote-tracking branch 'upstream/main' into ruby_versions_30mar…
7ecf51b 
…2023

Signed-off-by: Robin F. Pronk <robin.pronk@nedap.com>
@sonarcloud
Copy link

sonarcloud bot commented Aug 8, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
12.5% 12.5% Duplication

@rfpronk
Merge remote-tracking branch 'upstream/main' into ruby_versions_30mar…
596cfaa 
…2023

Signed-off-by: Robin F. Pronk <robin.pronk@nedap.com>
@sonarcloud
Copy link

sonarcloud bot commented Oct 3, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
14.9% 14.9% Duplication

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vkarve-chef vkarve-chef vkarve-chef left review comments

@poorndm poorndm poorndm approved these changes

@tpowell-progress tpowell-progress tpowell-progress left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@rfpronk @tpowell-progress @vkarve-chef @poorndm