Resolve new chefstyle warnings & use safe navigators #1507
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tim Smith <tsmith@chef.io>
phiggins
reviewed
Sep 8, 2020
lib/ohai/plugins/linux/network.rb
Outdated
| r.merge(dev: i) if r[:family] == family[:name] | ||
| end.compact | ||
| end | ||
| end&.compact |
There was a problem hiding this comment.
I think it'd be more readable to add a next unless iv[:routes] or similar at the top of the loop instead.
There was a problem hiding this comment.
yeah that's probably a good case where the alternative is most likely way more readable.
phiggins
reviewed
Sep 8, 2020
phiggins
reviewed
Sep 8, 2020
phiggins
approved these changes
Sep 8, 2020
We can avoid some duplicate checks by using &. in places Signed-off-by: Tim Smith <tsmith@chef.io>
|
(I kinda like the pretzel-dot operator, but some of these use cases are a bit funny) |
There's no need for the &. here Signed-off-by: Tim Smith <tsmith@chef.io>
Also add some notes here that we should convert this to a filter_map when we can as that's easier to read and faster. Perf benchmarks from the tubes: Signed-off-by: Tim Smith <tsmith@chef.io>
|
Nuked the weird ones. We should be good now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can avoid some duplicate checks by using &. in places