Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix the fixie #67

Merged
merged 6 commits into from Sep 20, 2022
Merged

fix the fixie #67

merged 6 commits into from Sep 20, 2022

Conversation

dheerajd-msys
Copy link
Contributor

@dheerajd-msys dheerajd-msys commented Jul 14, 2022

Signed-off-by: Dheeraj Singh Dubey dhsingh@progress.com

-- Change is solving the problem of bin/chef_fixie execution and now starting the console/prompt of fixie

Description

Related Issue

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (non-breaking change that does not add functionality or fix an issue)

Checklist:

  • I have read the CONTRIBUTING document.
  • I have run the pre-merge tests locally and they pass.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • All commits have been signed-off for the Developer Certificate of Origin.

Signed-off-by: Dheeraj Singh Dubey <dhsingh@progress.com>
@dheerajd-msys dheerajd-msys requested review from a team as code owners July 14, 2022 03:24
@dheerajd-msys dheerajd-msys mentioned this pull request Jul 14, 2022
10 tasks
Signed-off-by: Dheeraj Singh Dubey <dhsingh@progress.com>
Signed-off-by: Dheeraj Singh Dubey <dhsingh@progress.com>
Signed-off-by: Dheeraj Singh Dubey <dhsingh@progress.com>
Signed-off-by: Dheeraj Singh Dubey <dhsingh@progress.com>
Signed-off-by: Dheeraj Singh Dubey <dhsingh@progress.com>
@sonarcloud
Copy link

sonarcloud bot commented Jul 25, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link

@lbakerchef lbakerchef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall this looks good.

There are verify pipeline errors. Can these be fixed, or is there some reason they can't be fixed for now (like, this fix needs to be merged before the errors can be fixed)?

Also, can we see an adhoc and umbrella showing that this works?

@saghoshprogress saghoshprogress merged commit 05ce190 into main Sep 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants