Allow departments to be enabled/disabled by users #935
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Over in rubocop/rubocop#9752 we figured out that the reason end-users can't enable/disable Cookstyle departments is because `Enabled` isn't in the config and thus [can't be overridden](rubocop/rubocop#9752 (comment)). This change will allow a user to not only do the obvious: ```yaml Chef/Correctness: Enabled: false ``` But more interestingly do something like this: ```yaml AllCops: DisabledByDefault: true Chef/Correctness: Enabled: true ``` CC @jonas054 Signed-off-by: Phil Dibowitz <phil@ipom.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Over in rubocop/rubocop#9752 we figured out
that the reason end-users can't enable/disable Cookstyle departments is
because
Enabledisn't in the config and thus can't beoverridden.
This change will allow a user to not only do the obvious:
But more interestingly do something like this:
CC @jonas054
Types of changes
Checklist: