Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update RuboCop engine to 0.85 #634

Merged
merged 5 commits into from Jun 1, 2020
Merged

Update RuboCop engine to 0.85 #634

merged 5 commits into from Jun 1, 2020

Conversation

tas50
Copy link
Contributor

@tas50 tas50 commented May 21, 2020

Signed-off-by: Tim Smith tsmith@chef.io

@tas50 tas50 requested review from a team as code owners May 21, 2020 20:22
@tas50
Copy link
Contributor Author

tas50 commented May 26, 2020

This is on hold pending a release that fixes rubocop/rubocop#8035 and rubocop/rubocop#8012

tas50 added 3 commits June 1, 2020 09:36
Signed-off-by: Tim Smith <tsmith@chef.io>
Let's make sure folks clean up any cookbooks using this now deprecated
call

Signed-off-by: Tim Smith <tsmith@chef.io>
If someone wants to use get in their method names have at it.

Signed-off-by: Tim Smith <tsmith@chef.io>
Signed-off-by: Tim Smith <tsmith@chef.io>
@tas50 tas50 changed the title Vendor rubocop-0.84.0 upstream configuration. Update RuboCop engine to 0.85 Jun 1, 2020
It's actually a lot simpler now

Signed-off-by: Tim Smith <tsmith@chef.io>
@tas50
Copy link
Contributor Author

tas50 commented Jun 1, 2020

Unblocked now that 0.85 is out with the openssl fixes

@tas50 tas50 merged commit 70f7edf into master Jun 1, 2020
@chef-expeditor chef-expeditor bot deleted the 0.84 branch June 1, 2020 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant