Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enable Lint/UriEscapeUnescape #78

Merged
merged 1 commit into from Feb 19, 2020
Merged

enable Lint/UriEscapeUnescape #78

merged 1 commit into from Feb 19, 2020

Conversation

lamont-granquist
Copy link
Contributor

required for ruby 2.7

Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>
@tas50 tas50 merged commit 55a47f6 into master Feb 19, 2020
@chef-expeditor chef-expeditor bot deleted the lcg/uri-escape branch February 19, 2020 18:44
@lamont-granquist
Copy link
Contributor Author

NOTES:

  • None of the APIs are backwards compatible with URI.escape/unescape.

  • Different components need different kinds of normalization, URI.escape/unescape was safe to rip over the whole URI but it would miss some RFC violating edge conditions (which if they didn't ever come up weren't actually hurting anything, but the change is FORCING us to care about those edge conditions).

  • CGI.escape/unescape can be used for individual components

  • Addressable::URI.parse(uri_string).normalize.to_s is the best replacement solution for entire uris.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants