Enable FrozenStringLiteralComment and FrozenStringLiteralComment

Making sure we freeze all the literals saves memory and it's going to become the default in future Ruby so we should get on board
The encoding cop was previously disabled as it *added* the encoding comments. Now it removes them if they were setting utf-8 since that's the default on Ruby 2 and is totally pointless to set

Signed-off-by: Tim Smith <tsmith@chef.io>

Gemfile

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 source "https://rubygems.org"
 
 # Specify your gem's dependencies in chefstyle.gemspec

Rakefile

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require "bundler/gem_tasks"
 
 upstream = Gem::Specification.find_by_name("rubocop")

bin/chefstyle

@@ -1,6 +1,5 @@
 #!/usr/bin/env ruby
-# -*- encoding: utf-8 -*-
-
+# frozen_string_literal: true
 $LOAD_PATH.unshift File.join(File.dirname(__FILE__), %w{.. lib})
 
 require "chefstyle"

chefstyle.gemspec

@@ -1,4 +1,4 @@
-# coding: utf-8
+# frozen_string_literal: true
 lib = File.expand_path("../lib", __FILE__)
 $LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib)
 require "chefstyle/version"

config/chefstyle.yml

@@ -482,14 +482,18 @@ Style/WhileUntilModifier:
 Style/WordArray:
   Enabled: true
 
+# reduces memory usage
+Style/FrozenStringLiteralComment:
+  Enabled: true
+
+# we are ruby > 2.0 only so we can remove encoding comments for utf-8
+Style/Encoding:
+  Enabled: true
+
 #
 # Disabled Style
 #
 
-# FIXME: we need to enable this
-Style/FrozenStringLiteralComment:
-  Enabled: false
-
 # As of this commit we have 686 modules and classes without docs.
 # This is a cop that we /should/ have enabled, but tactically we can't really enable.
 Style/Documentation:
@@ -529,10 +533,6 @@ Style/FormatString:
 Style/IfUnlessModifier:
   Enabled: false
 
-# we are ruby > 2.0 only so can disable the Encoding cop
-Style/Encoding:
-  Enabled: false
-
 # Dan is -1 on this one: https://github.com/chef/chef/pull/4526#issuecomment-179950045
 Layout/IndentFirstHashElement:
   Enabled: false

lib/chefstyle.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require_relative "chefstyle/version"
 
 # ensure the desired target version of RuboCop is gem activated

lib/chefstyle/version.rb

@@ -1,4 +1,5 @@
+# frozen_string_literal: true
 module Chefstyle
-  VERSION = "1.1.3".freeze
-  RUBOCOP_VERSION = "0.87.1".freeze
+  VERSION = "1.1.3"
+  RUBOCOP_VERSION = "0.87.1"
 end