Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport: Chef-17 - Remove EOL warning #14367

Merged
merged 3 commits into from
Jun 4, 2024
Merged

Conversation

Stromweld
Copy link
Contributor

Description

Since there is no specific schedule for major releases having an eol message is irrelevant.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (non-breaking change that does not add functionality or fix an issue)

Checklist:

  • I have read the CONTRIBUTING document.
  • I have run the pre-merge tests locally and they pass.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • If Gemfile.lock has changed, I have used --conservative to do it and included the full output in the Description above.
  • All new and existing tests passed.
  • All commits have been signed-off for the Developer Certificate of Origin.

Signed-off-by: Corey Hemminger <hemminger@hotmail.com>
@Stromweld Stromweld requested review from a team as code owners May 1, 2024 15:20
Signed-off-by: Corey Hemminger <hemminger@hotmail.com>
@Stromweld Stromweld requested a review from a team as a code owner May 1, 2024 15:30
Signed-off-by: Corey Hemminger <hemminger@hotmail.com>
Copy link

sonarcloud bot commented May 1, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@Stromweld
Copy link
Contributor Author

@tpowell-progress more of the failed jobs are working now, the couple of failures left are not from the code change.

@tpowell-progress tpowell-progress merged commit 37b6737 into chef-17 Jun 4, 2024
32 of 35 checks passed
@tpowell-progress tpowell-progress deleted the backport_eol branch June 4, 2024 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants