New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chef_client_config: ensure config property directories exist #12416
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
create the various directories defined in the properties if they are defined and don't exist Signed-off by: Corey Hemminger <hemminger@hotmail.com>
Signed-off-by: Corey Hemminger <hemminger@hotmail.com>
Signed-off-by: Corey Hemminger <hemminger@hotmail.com>
Signed-off-by: Corey Hemminger <hemminger@hotmail.com>
Signed-off-by: Corey Hemminger <hemminger@hotmail.com>
@Stromweld Can you change one of the properties in https://github.com/chef/chef/blob/main/kitchen-tests/cookbooks/end_to_end/recipes/_chef_client_config.rb#L1 so we can get a bit of testing for this in the kitchen tests? |
tas50
changed the title
ensure config properties directories exist
chef_client_config: ensure config property directories exist
Dec 27, 2021
Signed-off-by: Corey Hemminger <hemminger@hotmail.com>
Signed-off-by: Corey Hemminger <hemminger@hotmail.com>
@tas50 is this what you're looking for? Looks like tests are passing but the 1 centos6 had an error connecting to a yum repo during it's test run. |
lamont-granquist
suggested changes
Jan 4, 2022
Signed-off-by: Corey Hemminger <hemminger@hotmail.com>
jaymzh
approved these changes
Jan 11, 2022
lamont-granquist
approved these changes
Jan 11, 2022
Thanks @Stromweld |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
create the various directories defined in the properties if they are defined and don't exist
Types of changes
Checklist:
Signed-off by: Corey Hemminger hemminger@hotmail.com