Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chef_client_config: ensure config property directories exist #12416

Merged
merged 12 commits into from Jan 14, 2022
Merged

chef_client_config: ensure config property directories exist #12416

merged 12 commits into from Jan 14, 2022

Conversation

Stromweld
Copy link
Contributor

@Stromweld Stromweld commented Dec 27, 2021

Description

create the various directories defined in the properties if they are defined and don't exist

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (non-breaking change that does not add functionality or fix an issue)

Checklist:

  • I have read the CONTRIBUTING document.
  • I have run the pre-merge tests locally and they pass.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • All commits have been signed-off for the Developer Certificate of Origin.

Signed-off by: Corey Hemminger hemminger@hotmail.com

create the various directories defined in the properties if they are defined and don't exist

Signed-off by: Corey Hemminger <hemminger@hotmail.com>
@Stromweld Stromweld requested review from a team as code owners December 27, 2021 22:12
@github-actions github-actions bot added the documentation How do we use this project? label Dec 27, 2021
Signed-off-by: Corey Hemminger <hemminger@hotmail.com>
Signed-off-by: Corey Hemminger <hemminger@hotmail.com>
Signed-off-by: Corey Hemminger <hemminger@hotmail.com>
Signed-off-by: Corey Hemminger <hemminger@hotmail.com>
@tas50
Copy link
Contributor

tas50 commented Dec 27, 2021

@Stromweld Can you change one of the properties in https://github.com/chef/chef/blob/main/kitchen-tests/cookbooks/end_to_end/recipes/_chef_client_config.rb#L1 so we can get a bit of testing for this in the kitchen tests?

Signed-off-by: Corey Hemminger <hemminger@hotmail.com>
@tas50 tas50 changed the title ensure config properties directories exist chef_client_config: ensure config property directories exist Dec 27, 2021
Signed-off-by: Corey Hemminger <hemminger@hotmail.com>
Signed-off-by: Corey Hemminger <hemminger@hotmail.com>
Signed-off-by: Corey Hemminger <hemminger@hotmail.com>
@Stromweld
Copy link
Contributor Author

@tas50 is this what you're looking for? Looks like tests are passing but the 1 centos6 had an error connecting to a yum repo during it's test run.

lib/chef/resource/chef_client_config.rb Outdated Show resolved Hide resolved
lib/chef/resource/chef_client_config.rb Outdated Show resolved Hide resolved
lib/chef/resource/chef_client_config.rb Outdated Show resolved Hide resolved
Signed-off-by: Corey Hemminger <hemminger@hotmail.com>
@tas50 tas50 merged commit 06185b3 into chef:main Jan 14, 2022
@tas50
Copy link
Contributor

tas50 commented Jan 14, 2022

Thanks @Stromweld

@Stromweld Stromweld deleted the patch-1 branch March 22, 2022 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation How do we use this project?
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants