Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #41: added eclipse ci #90

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

rnveach
Copy link
Member

@rnveach rnveach commented Nov 14, 2017

Issue #41

@romani We should update SH file to be able to get eclipse settings from a different project so we don't have to copy and paste it.

@rnveach
Copy link
Member Author

rnveach commented Nov 14, 2017

java.io.IOException: Cannot run program "/home/travis/build/checkstyle/regression-tool/.ci/eclipse-compiler-javac.sh" (in directory "/home/travis/build/checkstyle/regression-tool"): error=13, Permission denied

Windows doesn't mark it as executable. I need to switch to linux to fix.

@rnveach
Copy link
Member Author

rnveach commented Nov 14, 2017

@romani @Nimfadora

The type ImmutableGitChange is already defined

Do either of you know how to fix eclipse issue?
Files created by gson are placed into <base>\com\... instead of <base>\target\generated-sources\annotations\....

If I remove target/generated-sources/annotations from the SH so eclipse doesn't pull it in, then I get errors on that auto-generated code that should be ignored. I tried adding it to the nowarn with no change.

  1. ERROR in /media/checkstyle/regression-tool/com/github/checkstyle/regression/data/ImmutableGitChange.java (at line 237)
    The parameter path is hiding a field from type ImmutableGitChange.Builder

@romani
Copy link
Member

romani commented Nov 25, 2017

update SH file to be able to get eclipse settings from a different project so we don't have to copy and paste it.

Nothing is bad in such copy paste. It is better to keep the separate.

@rnveach
Copy link
Member Author

rnveach commented Dec 28, 2017

@romani @Nimfadora ping.
I still need help with #90 (comment)

@romani
Copy link
Member

romani commented Dec 29, 2017

@rnveach , please do copy paste of script and proceed, too much activity in projects to invest time in this issue

@rnveach
Copy link
Member Author

rnveach commented Dec 29, 2017

@romani

please do copy paste of script and proceed

This is the copy paste of the script and it is failing for the reasons I stated above.

@rnveach
Copy link
Member Author

rnveach commented Feb 2, 2019

@romani ping
I can try upgrading the copy/paste but I don't have any reason to believe it will help.

@romani
Copy link
Member

romani commented Feb 3, 2019

We should update SH file to be able to get eclipse settings from a different project so we don't have to copy and paste it.

Ok, let's update sh file in main project to take config from some env variable, if variable is not defined use default file ( that is now a config in main project).

I would recommend to suppress all rules that are failing now and start to invest in them only when project become to work.

@rnveach
Copy link
Member Author

rnveach commented Feb 3, 2019

@romani It is not a rule failure, it is a compile failure.

  1. ERROR in /home/travis/build/checkstyle/regression-tool/com/github/checkstyle/regression/data/ImmutableGitChange.java (at line 28)
    public final class ImmutableGitChange implements GitChange {
    ^^^^^^^^^^^^^^^^^^
    The type ImmutableGitChange is already defined

We have not even gotten to the point where it is giving us analysis errors.

@romani
Copy link
Member

romani commented Mar 3, 2019

I do not know, I need to spend time on this to investigate.
judging status of project, lets skip this CI execution for now, we will start investing in code quality ones project become usable.

I would recommend to skip all code quality requirements and brutally make this project to work at simple cases at least.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants