Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

minor: add openjdk21 to projects file for diff report generation #821

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

nrmancuso
Copy link
Member

No description provided.

@rnveach
Copy link
Member

rnveach commented Jan 20, 2024

@nrmancuso ping. What blocks this?

@nrmancuso
Copy link
Member Author

@nrmancuso ping. What blocks this?

I think this will make diff report execution take too long/too much memory. I need to reevaluate this. We should probably just replace 17 with 21, if it’s one or the other.

@romani
Copy link
Member

romani commented Jan 20, 2024

Only one jdk code is required for execution. Keep latest with exclusion on files that we can not parse yet.

@nrmancuso
Copy link
Member Author

Only one jdk code is required for execution. Keep latest with exclusion on files that we can not parse yet.

Agreed, they do a good job of keeping old inputs when possible, so we really shouldn’t miss anything by always using the latest version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants