Issue #7641: Adding code examples for HiddenField check

[aryaniiit002]

Issue #7641: Adding code examples for HiddenField check

[aryaniiit002]

Please review!
can i add Somefield in here and other words if come later?

[strkkk]

@aryaniiit002

can i add Somefield in here and other words if come later?

It is better to avoid words in whitelist, there should be a good reason for adding them to whitelist. Here reason is not good - please change name to something else.
Also, please correct code:

1. No need for main methods
2. Make examples same for all configs to show user difference
3. Format it properly (somewhere spaces are missing and left curly on next line)
4. Do not use var as variable name, it is confusing for users since it is reserved type name in java10+

[strkkk]

@aryaniiit002
I see that almost all my items are corrected, this is good.

Make examples same for all configs to show user difference

Please do that. Also I noticed that some examples do not have violation comments, only OK

Also CI is failing, please fix it.

[romani]

Github, generate website

[github-actions]

https://checkstyle-diff-reports.s3.us-east-2.amazonaws.com/HiddenFieldBranch_2021000346/index.html

https://checkstyle-diff-reports.s3.us-east-2.amazonaws.com/HiddenFieldBranch_2021000346/config_coding.html#HiddenField

[romani]

items:

[romani]

Github, generate website

[github-actions]

https://checkstyle-diff-reports.s3.us-east-2.amazonaws.com/HiddenFieldBranch_2021041004/index.html

https://checkstyle-diff-reports.s3.us-east-2.amazonaws.com/HiddenFieldBranch_2021041004/config_coding.html#HiddenField

[aryaniiit002]

this is an experiment.
please ignore

[aryaniiit002]

Diff Regression config: https://gist.githubusercontent.com/aryaniiit002/86e8279961bac2a91c0b6b3d948d6e60/raw/179ea72fb4b227d0954fd194f540f22e7eb3ca25/checkstyle_checks.xml
Diff Regression projects: https://gist.githubusercontent.com/aryaniiit002/97577199a93846562de23a0d6304e496/raw/1e822753136da53287c702a879090c63061936f2/projects-to-test-on.properties

[aryaniiit002]

GitHub, generate report

[strkkk]

@aryaniiit002 to generate report, you need to place all links it first post.
See https://github.com/checkstyle/contribution/tree/master/checkstyle-tester#executing-generation

If something is not clear in doc, fixes are welcome

[aryaniiit002]

first post means 1st comment?
so can i send new PR and do it there?

[strkkk]

first post means 1st comment?

it means first post in PR, it is #9234 (comment)

so can i send new PR and do it there?

Yes, but I do not understand why you need diff report. It is only for code changes, but you branch only has changes for documentation

[aryaniiit002]

i was kind of experimenting for something, i am working #7878 on this so i think may be regression might help basically my situation is similar to this #7982 (comment)

[strkkk]

@aryaniiit002 you need to do it either

1. In separate PR
2. on your local machine - https://github.com/checkstyle/contribution/blob/master/checkstyle-tester/README_MANUAL_EXECUTION.md#executing-diffgroovy

To compare diff it takes branch from PR, but current branch has no code changes, only docs

[romani]

@aryaniiit002 , you do not need regression diff report in this PR, we need web site.

[romani]

Github, generate web site

[github-actions]

https://checkstyle-diff-reports.s3.us-east-2.amazonaws.com/HiddenFieldBranch_2021145142/index.html

https://checkstyle-diff-reports.s3.us-east-2.amazonaws.com/HiddenFieldBranch_2021145142/config_coding.html#HiddenField

[romani]

items:

[romani]

Github, generate web site

[github-actions]

https://checkstyle-diff-reports.s3.us-east-2.amazonaws.com/HiddenFieldBranch_2021143105/index.html

https://checkstyle-diff-reports.s3.us-east-2.amazonaws.com/HiddenFieldBranch_2021143105/config_coding.html#HiddenField

[romani]

items:

[romani]

Github, generate web site

[github-actions]

https://checkstyle-diff-reports.s3.us-east-2.amazonaws.com/HiddenFieldBranch_2021153117/index.html

https://checkstyle-diff-reports.s3.us-east-2.amazonaws.com/HiddenFieldBranch_2021153117/config_coding.html#HiddenField