Support for all Token Types as a Property Type for Module Metadata #8802
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
romani
requested changes
Sep 7, 2020
Comment on lines
+679
to
+681
| <td>all tokens | ||
| <a href="apidocs/com/puppycrawl/tools/checkstyle/api/TokenTypes.html"> | ||
| allTokenTypes</a> |
There was a problem hiding this comment.
<a href="apidocs/com/puppycrawl/tools/checkstyle/api/TokenTypes.html">all tokens</a>
allTokenTypes we can keep only in metadata and javadoc.
| @@ -16,6 +16,9 @@ | |||
| about language structures. | |||
| </p></description> | |||
| <properties> | |||
| <property default-value="" name="tokens" type="allTokenTypes"> | |||
| <description>All checkstyle token types.</description> | |||
There was a problem hiding this comment.
this should be a description of property, not a description of type.
please use tokens to check
| } | ||
| final String typeName = typeNode.getTextContent().trim(); | ||
| final String typeName = | ||
| getCorrectNodeBasedOnPropertyType(property).getTextContent().trim(); |
There was a problem hiding this comment.
please try to move refactoring to separate commit of the same PR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#8801