-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue #8764: Create new check IllegalIdentifierName #8766
Issue #8764: Create new check IllegalIdentifierName #8766
Conversation
Github, generate report |
3b6cb1b
to
a443917
Compare
Github, generate report |
from wercker:
please fix indentation problem in html - https://nmancus1.github.io/site_illegalidentifiername/config_naming.html#IllegalIdentifierName for configs. |
@nmancus1 I suggest to extend list of illegal identifiers-keywords with '_' (underscore) - https://stackoverflow.com/questions/23523946/underscore-is-a-reserved-keyword FYI for new module report you should not use patch report generation, but new module link prefixes instead, it is clearer. https://github.com/checkstyle/contribution/tree/master/checkstyle-tester#basic-single-report |
This is a good suggestion, thanks.
Thank you, that is a good point. Should I amend and re-run report generation? |
I don't think it is necessary in this case, it is for future usages. |
4028cc2
to
2f13cea
Compare
I misunderstood this at first, I am updating this PR now. Edit: |
2f13cea
to
4e3d03d
Compare
src/main/java/com/puppycrawl/tools/checkstyle/checks/naming/IllegalIdentifierNameCheck.java
Show resolved
Hide resolved
Site is updated. |
Github, generate report |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor:
4e3d03d
to
2cdbb56
Compare
2cdbb56
to
cb1e152
Compare
codecov could be ignored. While jacoco and pitest are happy, codecov can be ignored. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
two minor changes please
src/main/java/com/puppycrawl/tools/checkstyle/checks/naming/IllegalIdentifierNameCheck.java
Show resolved
Hide resolved
src/main/java/com/puppycrawl/tools/checkstyle/checks/naming/IllegalIdentifierNameCheck.java
Outdated
Show resolved
Hide resolved
src/main/java/com/puppycrawl/tools/checkstyle/checks/naming/IllegalIdentifierNameCheck.java
Outdated
Show resolved
Hide resolved
cb1e152
to
0a02fb6
Compare
Issue #8764: Create new check IllegalIdentifierName
Diff Regression projects: https://gist.githubusercontent.com/nmancus1/e3988f8092d919b5cbe70f5359c4d9e8/raw/a0f6f5860f8025c19868061dee6e0e40960b992f/projects-to-test-on.properties
Diff Regression config: https://gist.githubusercontent.com/nmancus1/a6d651fb8e00bf39244b85c05ac809b8/raw/25957bb9583e66aaa6d4849838ecfae77eac2070/Base.xml
Diff Regression patch config: https://gist.githubusercontent.com/nmancus1/eb3dfff886148844a5b58523914109e3/raw/a20fbc07b5fd63f33c776fc20a1d2d725e86d735/IllegalIdentifierName.xml
Contribution PR: checkstyle/contribution#503
Link to site: https://nmancus1.github.io/site_illegalidentifiername/config_naming.html#IllegalIdentifierName