Issue #7977: Resolve Pitest Issues - JavadocMethodCheck (5) #8113
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The details are as follows that is the same in #7977
Pitest report
Link: https://huganghui.github.io/7977-JavadocMethodCheck-5/before-pitest-reports/com.puppycrawl.tools.checkstyle.checks.javadoc/JavadocMethodCheck.java.html#grouporg.pitest.mutationtest.report.html.SourceFile@1353848a_1077
Surviving mutations:
on line 1077: negated conditional → SURVIVED
Hardcoded mutation
mutation cs branch: HuGanghui@f5642b3
comment:
Looking at the pitest report, we can see that the surviving mutation is negated conditional → SURVIVED, so I change != -> == .
Regression diff report
https://huganghui.github.io//7977-JavadocMethodCheck-5/hardcoded-reports/diff/
there is no diff found.
Code Logic Analysis
Although there is no diff found in Regression diff report, I find that containing class ClassAlias and its relevant code is redundant, which also is mentioned in issue #7980 by @rnveach. So I do a diff report https://huganghui.github.io//7977-JavadocMethodCheck-5/remove-redundant-reports/diff/ on a branch(HuGanghui@20ad567) that remove class ClassAlias and its relevant code and result is no diff found. I also do Pitest after removing redundant code report show that it doesn't introduce new surviving mutations and solve all JavadocMethodCheck Pitest mutations including #7923, #7924, #7925, this issue, #7979, #7980 and Based on this result, I think maybe we can remove redundant code~