Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #7977: Resolve Pitest Issues - JavadocMethodCheck (5) #8113

Closed

Conversation

HuGanghui
Copy link
Contributor

@HuGanghui HuGanghui commented Apr 17, 2020

The details are as follows that is the same in #7977

Pitest report

Link: https://huganghui.github.io/7977-JavadocMethodCheck-5/before-pitest-reports/com.puppycrawl.tools.checkstyle.checks.javadoc/JavadocMethodCheck.java.html#grouporg.pitest.mutationtest.report.html.SourceFile@1353848a_1077

Surviving mutations:
on line 1077: negated conditional → SURVIVED

Hardcoded mutation

mutation cs branch: HuGanghui@f5642b3
comment:
Looking at the pitest report, we can see that the surviving mutation is negated conditional → SURVIVED, so I change != -> == .

Regression diff report

https://huganghui.github.io//7977-JavadocMethodCheck-5/hardcoded-reports/diff/
there is no diff found.

Code Logic Analysis

Although there is no diff found in Regression diff report, I find that containing class ClassAlias and its relevant code is redundant, which also is mentioned in issue #7980 by @rnveach. So I do a diff report https://huganghui.github.io//7977-JavadocMethodCheck-5/remove-redundant-reports/diff/ on a branch(HuGanghui@20ad567) that remove class ClassAlias and its relevant code and result is no diff found. I also do Pitest after removing redundant code report show that it doesn't introduce new surviving mutations and solve all JavadocMethodCheck Pitest mutations including #7923, #7924, #7925, this issue, #7979, #7980 and Based on this result, I think maybe we can remove redundant code~

@HuGanghui HuGanghui force-pushed the fix-javadocMethodCheck branch 3 times, most recently from 2ebd1a6 to bca8af1 Compare April 18, 2020 07:50
@gaurabdg
Copy link
Contributor

@HuGanghui With all due respect, I am working on it and a discussion is ongoing. I already sent a PR regarding these issues long back.

@HuGanghui
Copy link
Contributor Author

HuGanghui commented Apr 18, 2020

@gaurabdg yes, bro, I know you are working on #7980 for a long time and also know content discussion on it, i just working on #7977 and i think that removing redundant code maybe is a good solution, so provide this to Checkstyle. I think Pitest Issues of JavadocMethodCheck itself’s solution have some duplication that in order to resolving one may influence others.
As for the PR, I think @rnveach will properly resolve these PRs which may have some duplication~ If this PR is not proper, i am ok to close it.😊

@rnveach
Copy link
Member

rnveach commented May 19, 2020

Sorry @HuGanghui . We merged the other PR as he was being reviewed first and still discussing the scope of these changes.

@rnveach rnveach closed this May 19, 2020
@HuGanghui HuGanghui deleted the fix-javadocMethodCheck branch May 29, 2020 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants