Issue #7874: Resolve Pitest Issues - ImportOrderCheck (3) #7985
+27
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nrmancuso
force-pushed
the
Issue-7874-fix
branch
from
b359849
to
4070c2c
Compare
|
Just let me know if you want me to add |
|
If there is another example that doesn’t require also changing the whitelist then that could be nice, but it seems OK to me to add it, I wonder what other reviewers think. Nice fix! |
nrmancuso
force-pushed
the
Issue-7874-fix
branch
from
4070c2c
to
e16edf1
Compare
esilkensen
approved these changes
Apr 1, 2020
strkkk
approved these changes
Apr 2, 2020
|
@esilkensen please assign next person to review and request review from them after you approve changes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves Issue #7874: Resolve Pitest Issues - ImportOrderCheck (3)
PiTest Report, ran before changes, showing surviving mutation:
https://nmancus1.github.io/Issue-7874/com.puppycrawl.tools.checkstyle.checks.imports/ImportOrderCheck.java.html#org.pitest.mutationtest.report.html.SourceFile@7ea147e3_820
Surviving mutation:
removed conditional - replaced equality check with false → SURVIVEDPiTest Report, ran after changes, to show mutation was killed (updated):
https://nmancus1.github.io/Issue-7874/pitest_3/202003292351/com.puppycrawl.tools.checkstyle.checks.imports/ImportOrderCheck.java.html#org.pitest.mutationtest.report.html.SourceFile@2a2271dc_820