Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue #7914: add spoon project to no-exception testing #7930

Merged
merged 1 commit into from
Mar 23, 2020
Merged

Issue #7914: add spoon project to no-exception testing #7930

merged 1 commit into from
Mar 23, 2020

Conversation

Abhishek-kumar09
Copy link
Contributor

Fixes Issue #7914
Add spoon to no exception in wercker.sh

rnveach
rnveach requested changes Mar 21, 2020
View reviewed changes
Copy link
Member

@rnveach rnveach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes must also be made in wercker.yml to call new script in wercker.sh

@rnveach rnveach self-assigned this Mar 21, 2020
@Abhishek-kumar09
Copy link
Contributor Author

Thanks for guiding @rnveach, its done.

rnveach
rnveach approved these changes Mar 22, 2020
View reviewed changes
Copy link
Member

@rnveach rnveach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good to me.

@rnveach rnveach requested a review from strkkk March 22, 2020 14:39
@rnveach rnveach assigned strkkk and unassigned rnveach Mar 22, 2020
@strkkk strkkk merged commit 1b6408d into checkstyle:master Mar 23, 2020
@Abhishek-kumar09 Abhishek-kumar09 deleted the spoonNoException branch March 23, 2020 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rnveach rnveach rnveach approved these changes

@strkkk strkkk strkkk approved these changes

Assignees

@strkkk strkkk

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Abhishek-kumar09 @rnveach @strkkk