Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #7876: Fix for ImportOrderCheck(6) #7918

Merged
merged 1 commit into from May 29, 2020

Conversation

yajna-pandith
Copy link
Contributor

Issue #7876: Fix for ImportOrderChec(6)

@yajna-pandith
Copy link
Contributor Author

Diff I am generating

@rnveach
Copy link
Member

rnveach commented Mar 20, 2020

@yajna-pandith You may have provided fix for the issue but you have not provided any of the requested reports in the main issue at #7797 . We asked to see every step of the way to ensure you know how to work with pitest for the future.

@yajna-pandith
Copy link
Contributor Author

https://github.com/yajna-pandith/yajna-pandith.github.io
This repository contains the reports as requested in #7797 .

When tried to render html pages I am getting an error i am trying to resolve that.

@rnveach
Copy link
Member

rnveach commented Mar 21, 2020

Your reports seem to be working fine. https://yajna-pandith.github.io/pit-reports/202003200105/

Please post the link to all the reports.

@romani
Copy link
Member

romani commented Mar 23, 2020

render html pages I am getting an error i am trying to resolve that.

Please share a link (gist GitHub.com) to all output from report generator we will help.

@rnveach
Copy link
Member

rnveach commented Apr 12, 2020

@yajna-pandith ping

@rnveach rnveach self-requested a review April 12, 2020 21:38
@rnveach rnveach self-assigned this Apr 12, 2020
@romani
Copy link
Member

romani commented May 28, 2020

@yajna-pandith , ping, please finish PR.

UPDATE:
ok, looks like due to bunch of incomplete links this PR is stuck.

fixed links:
https://yajna-pandith.github.io/pit-reports-7876/202003220024/ (circleCI already have this report as artifact)
old: https://yajna-pandith.github.io/pit-reports-7876-mutation/202003200105/

https://yajna-pandith.github.io/diff-reports-7876/
https://yajna-pandith.github.io/site-reports-7876/

@romani romani assigned romani and unassigned rnveach May 28, 2020
@romani
Copy link
Member

romani commented May 28, 2020

PR is rebased on latest code, ok to merge ones CI pass.

@romani romani merged commit ff443eb into checkstyle:master May 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants