Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #7877: Fix for ImprtOrderCheck(6) #7902

Closed

Conversation

yajna-pandith
Copy link
Contributor

#7877: Fix for ImprtOrderCheck(6)

@wltan
Copy link
Contributor

wltan commented Mar 19, 2020

Please read the main issue #7797 again and follow the steps in there. It is not as simple as deleting code that causes surviving mutations.

If you want to remove code, you have to justify why that code is not used and can be safely removed without affecting functionality.

Otherwise, the code is actually being used, but our unit tests are not comprehensive enough to cover programming mistakes (mutations) in that section. In that case, you need to design new UTs that will (correctly) fail when the source code is mutated.

Whatever work you do needs to be accompanied by the relevant pitest and regression reports, as stated in the main issue.

@rnveach rnveach self-requested a review March 19, 2020 16:19
@rnveach rnveach self-assigned this Mar 19, 2020
Copy link
Member

@rnveach rnveach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Waiting on things @wltan mentioned. We need proof that all we can do is remove the code and why.

@romani
Copy link
Member

romani commented Mar 22, 2020

@yajna-pandith , ping, please provide prove that removal of code does not make any regression.
please generate diff report by checksgtyle-tester on all projects in properties file, please share report.

@romani
Copy link
Member

romani commented Aug 16, 2020

we lost connection to @yajna-pandith , PR is closed as incomplete.

@romani romani closed this Aug 16, 2020
@yajna-pandith yajna-pandith deleted the ynpandith-7877 branch August 19, 2020 14:10
@yajna-pandith yajna-pandith restored the ynpandith-7877 branch August 19, 2020 14:10
@yajna-pandith yajna-pandith deleted the ynpandith-7877 branch August 19, 2020 14:10
@yajna-pandith yajna-pandith restored the ynpandith-7877 branch August 19, 2020 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants