Issue #7801: Resolve Pitest Issues - AvoidStaticImportCheck

[gaurabdg]

Fixes #7801

Adds an UT for fixing the issue mentioned in #7801 (comment):

4. Regression and Code Logic Analysis

Although the results of the regression report wasn't useful, I have discovered an UT by analysing the code which tests a particular edge case of if(exclude.endsWith(".*")) . The reason the absence of the if statement didn't break the test codes:
if(exclude.endsWith(".*")) is redundant, since even if this check wasn't there and let's assume the exclude was a random member, it would yield true for the second condition but not for the first condition in if (classOrStaticMember.startsWith(excludeMinusDotStar)&& !classOrStaticMember.equals(excludeMinusDotStar)). and hence not move forward.

But if a specific exclude had a pattern like package.path.class.<member> where was a single letter ( for e.g. java.lang.Math.E) the absence of the if statement would yield that as if .E is .* and give a false positive. Hence, including this test case has forced the if statement to do an important check and the mutation was killed.

[strkkk]

@gaurabdg I guess you should remove the line with exclusion from pitest.sh which was in original issue to verify that you fixed it.

checkstyle/.ci/pitest.sh

Line 76 in abf829f

"AvoidStaticImportCheck.java.html:<td class='covered'><pre><span class='survived'> if (exclude.endsWith(&#34;.*&#34;)) {</span></pre></td></tr>"

[gaurabdg]

@strkkk Sorry, totally missed that, but nevertheless I tested locally and had uploaded the pitest-report in the issue, the mutation is taken care of. Here is the link: https://gaurabdg.github.io/checkstyle-tester-reports/pitest/AvoidStaticImport-fixed/index.html

[rnveach]

I guess you should remove the line with exclusion from pitest.sh which was in original issue to verify that you fixed it.

CI will fail if mutation is killed but left in file that only lists surviving mutants. The only thing that needs to be watched out for is CI passing and the file not being modified. Then this means the mutation was not killed and still survives. When this happens, the new test case that was added is not fulfilling its role that it was designed for.

I will add a new step in the main issue for this, but you should post the new pitest report when you add the test case to show the mutation is actually being killed now as a final confirmation.

[rnveach]

Everything I have seen satisfies me. CI will find any remaining issues I would have.

[gaurabdg]

I will add a new step in the main issue for this, but you should post the new pitest report when you add the test case to show the mutation is actually being killed now as a final confirmation.

I did it in the #7801 (comment):

Pitest Report after the fix: https://gaurabdg.github.io/checkstyle-tester-reports/pitest/AvoidStaticImport-fixed/index.html