Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue 7487 add method hasChildren() to DetailAST #7489

Merged
merged 2 commits into from Jan 26, 2020
Merged

Issue 7487 add method hasChildren() to DetailAST #7489

merged 2 commits into from Jan 26, 2020

Conversation

pbludov
Copy link
Member

@pbludov pbludov commented Jan 17, 2020 •
edited

Issue #7487

First commit to add the method.
Second commit to switch ast.getChildCount() > 0 to ast.hasChildren() and ast.getChildCount() == 0 to !ast.hasChildren()

Some if's are inverted for readablity. The method isOnEnumConstant is rewritten to eliminate multiple calls to getPrevSiblingSkipComments

Regression

InvalidJavadocPosition, DesignForExtension, JavadocContentLocation, MissingJavadocPackage

AtclauseOrder, JavadocBlockTagLocation, JavadocParagraph, JavadocTagContinuationIndentation, MissingDeprecated, NonEmptyAtclauseDescription, SingleLineJavadoc, SummaryJavadoc

SummaryJavadoc only

@romani
Copy link
Member

romani commented Jan 17, 2020

@pbludov , please rebase on latest code, I pushed fixes for violations that was caused by PR merged from previous year. @strkkk ,fyi.

@pbludov pbludov changed the title Issue 7487 has children Issue 7487 add method hasChildren() to DetailAST Jan 17, 2020
@pbludov pbludov mentioned this pull request Jan 18, 2020
Merged
@pbludov pbludov added blocked and removed blocked labels Jan 18, 2020
@pbludov
Copy link
Member Author

pbludov commented Jan 20, 2020

Rebased to fix the CI.

@rnveach rnveach mentioned this pull request Jan 20, 2020
Open
@romani romani self-assigned this Jan 20, 2020
romani
romani requested changes Jan 25, 2020
View reviewed changes
Copy link
Member

@romani romani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

items:

src/main/java/com/puppycrawl/tools/checkstyle/utils/BlockCommentPosition.java Show resolved Hide resolved
src/test/java/com/puppycrawl/tools/checkstyle/DetailAstImplTest.java Outdated Show resolved Hide resolved
@romani romani assigned pbludov and unassigned romani Jan 25, 2020
@pbludov pbludov force-pushed the issue-7487-has-children branch 2 times, most recently from c1be1f7 to 394c696 Compare January 25, 2020 09:30
@pbludov pbludov assigned romani and unassigned pbludov Jan 25, 2020
@romani romani assigned pbludov and unassigned romani Jan 25, 2020
@pbludov pbludov assigned romani and unassigned pbludov Jan 25, 2020
@romani romani merged commit bd45909 into checkstyle:master Jan 26, 2020
@pbludov pbludov deleted the issue-7487-has-children branch January 26, 2020 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@romani romani romani requested changes

@rnveach rnveach rnveach approved these changes

@strkkk strkkk strkkk approved these changes

Assignees

@romani romani

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@pbludov @romani @rnveach @strkkk