Issue #6916: migrate tests to junit5 for annotation package

[pbludov]

Issue #6916

Auto converted to Junit5 with IDEA inspections.
As a side effect, some imports replaced with static imports.

[romani]

I am fine with static import in tests.

item

[romani]

does it make sense to do this on top level, and explicitly allow junit in packages that are not converted yet?

[pbludov]

No, this is a temporary config. I will add processed packages here so that no one accidentally adds a junit4 test during the migration. Once all tests will use juni5, this section will be removed. Junit4 package annotations will not be available because the junit4 module will be removed from the pom.xml and this section will not be needed any more.

[romani]

I meant something like:
https://github.com/checkstyle/checkstyle/blob/master/config/import-control.xml#L15
https://github.com/checkstyle/checkstyle/blob/master/config/import-control.xml#L70

and it will works same during migration, and in each commit/PR , you will remove allow for certain package so so at the end config will self cleanup.

[pbludov]

done. Now Junit4 globally forbidden and explicitly enabled for every test except tests in checks/annotation package. During migration, the allowed package list will shrink until it is empty.

[pbludov]

IDEA inspections fails to recognize assertArrayEquals method as an assert method:

https://teamcity.jetbrains.com/viewLog.html?buildId=2660367&tab=Inspection&buildTypeId=Checkstyle_IdeaInspectionsPullRequest

It's upsetting. I'll try to use Google Truth assertions instead.

[romani]

try to remove static import and help IDEA to recognize it.
and please recheck that inspection config should be updated:

I'll try to use Google Truth assertions instead.

it is better to no overcomplicate PRs with extra update.

[rnveach]

@pbludov @romani It is more concerning that pitest does not like junit5. This may be a bigger deal breaker than TC complaining.

https://circleci.com/gh/pbludov/checkstyle/2995?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link

Caused by: org.apache.maven.plugin.MojoFailureException: Mutation score of 0 is below threshold of 100

Pitest says we lost all coverage.

Looks like we might need a new dependency for pitest. https://github.com/pitest/pitest-junit5-plugin

[pbludov]

Looks like we might need a new dependency for pitest. https://github.com/pitest/pitest-junit5-plugin

It works, thank you.

[pbludov]

please recheck that inspection config should be updated:

Done.

[romani]

last item:

[rnveach]

Shippable still hasn't finished. TC can be ignored.

[romani]

It is better to not ignore, but recheck that violations are same as in master