Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #6207: Add xpath regression test for AnonInnerLength #6978

Merged
merged 1 commit into from
Aug 15, 2019

Conversation

mincong-h
Copy link
Contributor

This PR adds XPath regression test for suppression filter on AnonInnerLength check, see #6207.


import java.util.Comparator;

public class SuppressionXpathRegressionAnonInnerLength {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All input files should start with Input.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

non of existing is named like "InputXxxxxxxx" ....
@timurt , do you remember why we did not followed general rule for input test java files ?

@rnveach , I think it should not be blocker for this PRs, as find a reason, or no reason, we can improve in next PRs.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR is merged, but if @timurt share reason, it would be good.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@romani it seems that idea was to separate tests and inputs for Checks and for Xpath Generator I guess

I do not actually remember whole context, but please read this discussion, I think it all came from there :)

@romani romani merged commit af28b80 into checkstyle:master Aug 15, 2019
@mincong-h mincong-h deleted the issue-6207-AnonInnerLength branch August 16, 2019 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants