Issue #6207: Add xpath regression test for AbstractClassName #6977
Conversation
| @@ -0,0 +1,4 @@ | |||
| package org.checkstyle.suppressionxpathfilter.abstractclassname; | |||
|
|
|||
| public abstract class SuppressionXpathRegressionAbstractClassNameOne { // warn | |||
There was a problem hiding this comment.
SuppressionXpathRegressionAbstractClassNameOne
it is better to make some reasonable names if possible.
For example:
SuppressionXpathRegressionAbstractClassNameTop
SuppressionXpathRegressionAbstractClassNameInner
SuppressionXpathRegressionAbstractClassNameNoModifier
we did bad naming of "...One/....Two" only when we have no idea how to name them, or name will be too long.
test methods should be named in same patterns:
testModifierOne => testNoModifier
There was a problem hiding this comment.
Sure, let me change them.
There was a problem hiding this comment.
@romani Correct me if I am wrong, but all input files should start with Input.
It looks like our test to catch this isn't looking at the IT tier.
There was a problem hiding this comment.
lets proceed as we have now, after reply of @timurt , I will make a decision.
mincong-h
force-pushed
the
issue-6207-AbstractClassNameCheck
branch
from
63d0a11
to
6db83d5
Compare
This PR adds XPath regression test for suppression filter on AbstractClassName check, see #6207.