Issue #6207: Add xpath regression test for UnusedImports #6975
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mincong-h
commented
Aug 13, 2019
src/it/java/org/checkstyle/suppressionxpathfilter/XpathRegressionUnusedImportsTest.java
Outdated
Show resolved
Hide resolved
mincong-h
commented
Aug 13, 2019
src/it/java/org/checkstyle/suppressionxpathfilter/XpathRegressionUnusedImportsTest.java
Outdated
Show resolved
Hide resolved
mincong-h
force-pushed
the
issue-6207-expand-xpath-it-regression-testing
branch
from
8b57a21
to
fc00575
Compare
pbludov
approved these changes
Aug 15, 2019
| }; | ||
|
|
||
| final List<String> expectedXpathQueries = Collections.singletonList( | ||
| "/IMPORT/DOT[./IDENT[@text='List']]/DOT/IDENT[@text='java']"); |
There was a problem hiding this comment.
This will suppress any import that matches import java.*.List, i.e.
import java.otherpackage.List;
I'm not sure they ever exist, so it's OK. However, the bad thing is that users can use this xpath as an example.
There was a problem hiding this comment.
@pbludov I believe this regression should be checking the output from the CLI when verifying the xpath. If you feel it is being too loose, then please make an issue on it.
rnveach
approved these changes
Aug 16, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds XPath regression test for suppression filter on UnusedImports check, see #6207.