Issue #6439: move powermock tests away from the normal tests

[rnveach]

Issue #6439

I am expecting pitest to fail until I add new suppressions.

[rnveach]

These are ok since they use reflection and not byte code hacking.

[rnveach]

Can't tag the class for powermock since it is package private.

[rnveach]

Can't tag the class for powermock since it is package private.

[rnveach]

With powermock gone, the false positives went away too.

[romani]

We got bunch of items to our ignore list, but what we get as benefits ?

[rnveach]

@romani The biggest benefit is the pitests run faster. We are talking 36.3 minutes versus 84.9 minutes, so that saves us 48 minutes.
I also mentioned in the issue the other benefits where powermock kept screwing us.
Some of the pitest.sh additions are simply because we overrely on powermock. PackageNamesLoader is the best example. It is hard coded to only bring in packages from a specific file. We had to use powermock because we couldn't modify the file in main. This class can easily be fixed to just need reflection to "pretend" we got the values from the file.

As always, I will continue to work on killing the list of mutants.

Old Times:

Total time: 00:01
Total time: 00:40
Total time: 03:43 min
Total time: 01:06 min
Total time: 02:07 min
Total time: 05:47 min
Total time: 00:37
Total time: 02:02 min
Total time: 01:28 min
Total time: 04:04 min
Total time: 03:15 min
Total time: 00:27
Total time: 01:06 min
Total time: 00:30
Total time: 00:25
Total time: 00:18
Total time: 00:55
Total time: 10:48 min
Total time: 01:38 min
Total time: 07:23 min
Total time: 01:13 min
Total time: 19:24 min
Total time: 03:57 min
Total time: 03:07 min
Total time: 01:46 min
Total time: 02:23 min
Total time: 01:03 min
Total time: 03:44 min

New Times:

Total time: 00:01
Total time: 00:46
Total time: 01:22 min
Total time: 01:06 min
Total time: 02:07 min
Total time: 05:51 min
Total time: 00:38
Total time: 01:04 min
Total time: 00:50
Total time: 04:05 min
Total time: 02:52 min
Total time: 00:30
Total time: 01:06 min
Total time: 00:31
Total time: 00:24
Total time: 00:19
Total time: 00:55
Total time: 00:20
Total time: 00:09
Total time: 01:38 min
Total time: 00:17
Total time: 00:47
Total time: 01:01 min
Total time: 01:45 min
Total time: 00:40
Total time: 01:20 min
Total time: 00:17
Total time: 03:41 min

The longest running job is 5 minutes instead of 19 minutes. Second longest job is 4 minutes instead of 10 minutes.

[rnveach]

@romani I will work on killing some bigger gaps in this PR, starting with PackageNamesLoader. It is basically like swapping powermock tests for normal tests.

Edit: All powermock tests for PackageNamesLoader were changed to normal tests. No reflection was used.
Edit: 1 was swapped for HeaderCheck, the other can't be swapped because StringReader is pretty much exception safe but can only throw an exception if the Reader is closed more then once, which is impossible to do without powermock.

[romani]

Ok to merge

[rnveach]

@romani CI is green. Do you want to merge as 3 commits or want me to squash them?

[romani]

Whatever.

[rnveach]

I squashed the commits and will merge when CI is done.