Issue #6440: AnnotationLocation: named parameters must be considered parameters #6444
Conversation
|
Strange that no changes in Google's Report is good, code changes are good. |
…onsidered parameters
done |
| * allowSamelineSingleParameterlessAnnotation = false | ||
| * allowSamelineParameterizedAnnotation = false | ||
| * allowSamelineMultipleAnnotations = true | ||
| */ |
There was a problem hiding this comment.
Can we have some warnings in this file ?
There was a problem hiding this comment.
No. with allowSamelineMultipleAnnotations = true both allowSamelineSingleParameterlessAnnotation and allowSamelineParameterizedAnnotation has no effect. Actually, this means that any combination of annotations is allowed.
However, it is possible to catch a violation by using annotations on different lines.
This one: https://github.com/checkstyle/checkstyle/blob/master/src/main/java/com/puppycrawl/tools/checkstyle/checks/annotation/AnnotationLocationCheck.java#L292
But this is a different case and should be covered by another set of tests.
Issue #6440
Regression report: https://pbludov.github.io/issue-6440/