Issue #5759: Update AbstractChecks to log DetailAST (part 1) #6221
Conversation
|
@romani Do we require xpath tests for every check in this issue? |
|
Yes, we demanded this before, we need to keep doing it, as it is the only reason to have such change. |
pbludov
changed the title
pbludov
force-pushed
the
issue-5759
branch
2 times, most recently
from
46cfb63
to
68bf3d0
Compare
pbludov
changed the title
pbludov
changed the title
done. |
|
@pbludov , thanks a lot for update. Is it possible to split this PR in few ? by Check or by package to make review easier. There are changes in test expectations that I would like to attentively review. |
| "20:38: " + getCheckMessage(messages, msgPreceded, "<"), | ||
| "20:40: " + getCheckMessage(messages, msgFollowed, "<"), | ||
| "20:61: " + getCheckMessage(messages, msgPreceded, ">"), | ||
| "12:17: " + getCheckMessage(messages, msgFollowed, "<"), |
There was a problem hiding this comment.
+1 is correct, verified at InputWhitespaceAroundGenerics, symbol < is at 17 column.
|
@pbludov , verification of such big update is very complicated. |
Issue #5759
Regression tests:
https://pbludov.github.io/issue-5759/
Note that patch version reports a bit more violations, for example:
https://pbludov.github.io/issue-5759/checkstyle/index.html#A1151