Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #5758: converted other line/column checks to log ast #6198

Merged
merged 1 commit into from
Nov 10, 2018

Conversation

rnveach
Copy link
Member

@rnveach rnveach commented Nov 4, 2018

Issue #5758

This fixes all checks in the issue.

@rnveach
Copy link
Member Author

rnveach commented Nov 4, 2018

Regression: http://rveach.no-ip.org/checkstyle/regression/reports/186/

Shows no differences.

@romani
Copy link
Member

romani commented Nov 9, 2018

@rnveach , thanks a lot.
Changes looks good.

previously we agreed to append tests to https://github.com/checkstyle/checkstyle/tree/master/src/it/java/org/checkstyle/suppressionxpathfilter for each Check that become xpath compliant.

@rnveach
Copy link
Member Author

rnveach commented Nov 9, 2018

Some changes were done in #6121 and were not added to xpath list and not added for regression.
Other checks are missing in regression that are already listed too.

@romani
Copy link
Member

romani commented Nov 10, 2018

This is my bad, that I forgot about this. @pbludov actually made statement that extra work should be done is scope of #5758.

If you want to postpone it update, please create separate issue on this with label "easy".

@rnveach
Copy link
Member Author

rnveach commented Nov 10, 2018

Done at #6207 .

@romani romani merged commit f90ad7d into checkstyle:master Nov 10, 2018
@rnveach rnveach deleted the issue_5758 branch November 10, 2018 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants