Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue #13213: Remove '//ok' comments from InputJavadocMethodProtected… #14834

Merged
merged 1 commit into from Apr 30, 2024
Merged

Issue #13213: Remove '//ok' comments from InputJavadocMethodProtected… #14834

merged 1 commit into from Apr 30, 2024

Conversation

prathm3
Copy link
Contributor

@prathm3 prathm3 commented Apr 26, 2024

Issue #13213

Removed //ok comments from InputJavadocMethodProtected also removed suppressions for same.

MANISH-K-07
MANISH-K-07 reviewed Apr 29, 2024
View reviewed changes
Copy link
Contributor

@MANISH-K-07 MANISH-K-07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@prathm3 , looks like you missed a few comments
https://dev.azure.com/romanivanovjr/romanivanovjr/_build/results?buildId=21232&view=logs&j=e663805c-ee13-5a24-f979-d725e0346c8e&t=40ff6e43-c5d7-5753-f947-23012624b0c6&l=1813

@prathm3 prathm3 force-pushed the RemoveOkCommentfromInputJavadocMethodProtected branch from 51313e9 to 18b66c6 Compare April 29, 2024 17:30
@prathm3
Copy link
Contributor Author

prathm3 commented Apr 29, 2024

@prathm3 , looks like you missed a few comments https://dev.azure.com/romanivanovjr/romanivanovjr/_build/results?buildId=21232&view=logs&j=e663805c-ee13-5a24-f979-d725e0346c8e&t=40ff6e43-c5d7-5753-f947-23012624b0c6&l=1813

Thanks @MANISH-K-07, Done with changes.

romani
romani approved these changes Apr 30, 2024
View reviewed changes
Copy link
Member

@romani romani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok to merge

@romani romani merged commit c4d557c into checkstyle:master Apr 30, 2024
112 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MANISH-K-07 MANISH-K-07 MANISH-K-07 left review comments

@romani romani romani approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@prathm3 @romani @MANISH-K-07