New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue #14631: Updated Version literal to new AST format #14823
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Items:
* |--VERSION_LITERAL -> @version | ||
* |--WS -> | ||
* `--DESCRIPTION -> DESCRIPTION | ||
* |--TEXT -> 1.3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@prathm3 , please trim AST upto line 271. This is the only part that we have to document.
We don't need the below lines 272, 273 and also please remove blank line at 274.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
Single commit please |
736bc35
to
2dd3253
Compare
50637b8
to
1fc5987
Compare
e837b97
to
7fc93b1
Compare
Done. Please review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok to merge.
Thanks a lot!
Issue: #14631