New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue #14631: Updated See literal to new AST format #14818
Issue #14631: Updated See literal to new AST format #14818
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Item:
src/main/java/com/puppycrawl/tools/checkstyle/api/JavadocTokenTypes.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please squash and rebase to single commit to make CI green
src/main/java/com/puppycrawl/tools/checkstyle/api/JavadocTokenTypes.java
Show resolved
Hide resolved
14eb3c8
to
f50c915
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok to merge if CI pass
@romani , Just pointing out, there are still 2 commits in this PR.. |
thanks a lot for hint. @prathm3 , please squash commits in one commit. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
see above
f50c915
to
e4bac3d
Compare
* |--LEFT_BRACE[3x46] : [(] | ||
* |--ARGUMENT[3x47] : [Object] | ||
* |--RIGHT_BRACE[3x53] : [)] | ||
* |--JAVADOC_TAG -> JAVADOC_TAG |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@prathm3 , looks like you dropped the latest commit instead of squash.
The suggested changes are reverted now. Please see to it....
https://checkstyle.org/beginning_development.html contains good documentation on rebase steps
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@MANISH-K-07 Thank you for your help. This is my first squashed commit. I have squashed changes. Please let me know any changes required.
34bdd69
to
49ea489
Compare
* JAVADOC_TAG -> JAVADOC_TAG | ||
* |--SEE_LITERAL -> @see | ||
* |--WS -> | ||
* |--REFERENCE -> REFERENCE |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The 3 lines above are spaced one extra I think.
@prathm3 , could you please recheck with AST from cli?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
e9df57c
to
f4bcaad
Compare
Issue: #14631