Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #13213: Remove // ok comments from input files #14742

Closed
wants to merge 14 commits into from

Conversation

AadhilMR
Copy link

Removed UnnecessaryOkComment suppressions from checkstyle-input-supression.xml file and // ok comment from InputVariableDeclarationUsageDistanceIfStatement.java

@AadhilMR AadhilMR changed the title Remove // ok comments from input files Issue #13213: Remove // ok comments from input files Mar 30, 2024
Copy link
Contributor

@MANISH-K-07 MANISH-K-07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AadhilMR , Please revert these changes and remove only the suppression related to the file you have removed "// ok" from. You can refer through previously merged PRs to see how they were done.

Also, please squash and rebase to single commit

@nrmancuso
Copy link
Member

@AadhilMR I am moving this PR to draft state, please move back to review state after you get extra commits sorted out.

@nrmancuso nrmancuso marked this pull request as draft April 2, 2024 02:40
@nrmancuso
Copy link
Member

Looks like we have lost contact with the author, I am closing this PR

@nrmancuso nrmancuso closed this May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants