Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue #6207: Add Xpath regression test for MethodTypeParameterName #14717

Merged
merged 1 commit into from
Mar 26, 2024
Merged

Issue #6207: Add Xpath regression test for MethodTypeParameterName #14717

merged 1 commit into from
Mar 26, 2024

Conversation

Kexin2000
Copy link
Contributor

Part of issue #6207

MANISH-K-07
MANISH-K-07 reviewed Mar 26, 2024
View reviewed changes
Copy link
Contributor

@MANISH-K-07 MANISH-K-07 left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please don't merge this before #14713

#14713 consists of two commits and I won't be able to squash this current PR's xpath file suppression into the first commit and it might get messy..

@romani
Copy link
Member

romani commented Mar 26, 2024

#14713 is merged

romani
romani approved these changes Mar 26, 2024
View reviewed changes
Copy link
Member

@romani romani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok to merge

@romani romani merged commit 9846c80 into checkstyle:master Mar 26, 2024
113 of 114 checks passed
@MANISH-K-07
Copy link
Contributor

MANISH-K-07 commented Mar 26, 2024 •
edited

Ok to merge

@romani , this commit still consists of files named with old pattern and there is no suppression for this check.
There are supposed to be failing integration workflows on rebase 😕

EDIT : Just as expected,

image

https://dev.azure.com/romanivanovjr/romanivanovjr/_build/results?buildId=20733&view=logs&j=c902ebb4-c9f8-5f09-4e17-ff78fbbc842e&t=9ca98c81-ff64-58f0-9d03-a23ac1c4a111&l=1315

This commit needs to be reverted to fix leak in master

@romani
Copy link
Member

romani commented Mar 26, 2024

@MANISH-K-07 , please send fix to fix it forward. Just one check update, I will merge immediately

@MANISH-K-07
Copy link
Contributor

Give me 5 mins

@MANISH-K-07 MANISH-K-07 mentioned this pull request Mar 26, 2024
Merged
@MANISH-K-07
Copy link
Contributor

@MANISH-K-07 , please send fix to fix it forward. Just one check update, I will merge immediately

Give me 5 mins

@romani , please see PR #14719

@Kexin2000 Kexin2000 deleted the expandXpathRegressionTesting branch March 26, 2024 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MANISH-K-07 MANISH-K-07 MANISH-K-07 left review comments

@romani romani romani approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Kexin2000 @romani @MANISH-K-07