Issue #13086: InnerAssignmentCheck failed for one line code in Java 1…

[aayushRedHat]

Related: #13086
Diff Regression config: https://gist.githubusercontent.com/aayushRedHat/7197864ed054dca9580c0cc8c441c1fd/raw/ae6d36be203f1228e0dbb013941c8a29ce6427b6/gistfile1.txt

[aayushRedHat]

Github, generate report

[github-actions]

https://checkstyle-diff-reports.s3.us-east-2.amazonaws.com/b45b11c_2023081827/reports/diff/index.html

[nrmancuso]

Let's get hanging PRs across the finish line before we begin review here: https://github.com/checkstyle/checkstyle/pulls/aayushRedhat

[aayushRedHat]

Let's get hanging PRs across the finish line before we begin review here: https://github.com/checkstyle/checkstyle/pulls/aayushRedhat

Please review @nrmancuso @romani

[romani]

ok to merge, report is good

[rnveach]

Nevermind, I thought this was a swap, but I see it is an addition.

As a note, no test case was ever added for #377 .

[nrmancuso]

Item:

[nrmancuso]

Please add more test cases:

    boolean flag;

    void m1(final String operation) {
        boolean innerFlag;
        innerFlag = switch (operation) {
            case "Y" -> flag = true; // expected violation
            case "N" -> {
                yield flag = false; // expected violation
            }
            default -> throw new UnsupportedOperationException();
        };
    }

    void m2(final String operation) {
        boolean innerFlag;
        switch (operation) {
            case "Y": flag = true; break; // should be ok
            case "N": {
                flag = false; // should be ok
                break;
            }
            default: throw new UnsupportedOperationException();
        }
    }

    void m3(final String operation) {
        boolean innerFlag;
        switch (operation) {
            case "Y" -> flag = innerFlag = true; // expected violation
            case "N" -> {
                flag = innerFlag = false; // expected violation
            }
            default -> throw new UnsupportedOperationException();
        }
    }

[nrmancuso]

@aayushRedHat ping

[aayushRedHat]

@aayushRedHat ping

Sorry @nrmancuso @romani for the delay in my PR. I was on Holidays, will start working tomorrow.

[nrmancuso]

We lost contact with PR author, anyone is welcome to pick this up and reuse the code here